Fix a bug when loading DruidDatasource. #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
|
| if self.datasource.cache_timeout: | ||
| return self.datasource.cache_timeout | ||
| if hasattr(self.datasource, 'database') \ | ||
| and self.datasource.database.cache_timeout: |
There was a problem hiding this comment.
It exceeds the line limit, which Max set to be 90 @hongbozeng
|
|
|
Coverage decreased (-0.04%) to 71.139% when pulling e598e2867d23369ecb539e5d1fb0daac044acfc3 on kim/fix_druid_datasource_bug into fd40742 on master. |
coleslaw
force-pushed
the
kim/fix_druid_datasource_bug
branch
from
e598e28
to
e5553ab
Compare
graceguo-supercat
pushed a commit
to graceguo-supercat/superset
that referenced
this pull request
Oct 4, 2021
…rement (apache#213) Updates the requirements on [@superset-ui/legacy-preset-chart-big-number](https://github.com/apache-superset/superset-ui-plugins) to permit the latest version. - [Release notes](https://github.com/apache-superset/superset-ui-plugins/releases) - [Changelog](https://github.com/apache-superset/superset-ui-plugins/blob/master/CHANGELOG.md) - [Commits](apache-superset/superset-ui-plugins@v0.10.0...v0.11.0) Signed-off-by: dependabot-preview[bot] <[email protected]>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
…rement (apache#213) Updates the requirements on [@superset-ui/legacy-preset-chart-big-number](https://github.com/apache-superset/superset-ui-plugins) to permit the latest version. - [Release notes](https://github.com/apache-superset/superset-ui-plugins/releases) - [Changelog](https://github.com/apache-superset/superset-ui-plugins/blob/master/CHANGELOG.md) - [Commits](apache-superset/superset-ui-plugins@v0.10.0...v0.11.0) Signed-off-by: dependabot-preview[bot] <[email protected]>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
Updates the requirements on [@data-ui/event-flow](https://github.com/williaster/data-ui) to permit the latest version. - [Release notes](https://github.com/williaster/data-ui/releases) - [Changelog](https://github.com/williaster/data-ui/blob/master/CHANGELOG.md) - [Commits](williaster/data-ui@v0.0.80...v0.0.81) Signed-off-by: dependabot-preview[bot] <[email protected]>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
…rement (apache#213) Updates the requirements on [@superset-ui/legacy-preset-chart-big-number](https://github.com/apache-superset/superset-ui-plugins) to permit the latest version. - [Release notes](https://github.com/apache-superset/superset-ui-plugins/releases) - [Changelog](https://github.com/apache-superset/superset-ui-plugins/blob/master/CHANGELOG.md) - [Commits](apache-superset/superset-ui-plugins@v0.10.0...v0.11.0) Signed-off-by: dependabot-preview[bot] <[email protected]>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
Updates the requirements on [@data-ui/event-flow](https://github.com/williaster/data-ui) to permit the latest version. - [Release notes](https://github.com/williaster/data-ui/releases) - [Changelog](https://github.com/williaster/data-ui/blob/master/CHANGELOG.md) - [Commits](williaster/data-ui@v0.0.80...v0.0.81) Signed-off-by: dependabot-preview[bot] <[email protected]>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
…rement (apache#213) Updates the requirements on [@superset-ui/legacy-preset-chart-big-number](https://github.com/apache-superset/superset-ui-plugins) to permit the latest version. - [Release notes](https://github.com/apache-superset/superset-ui-plugins/releases) - [Changelog](https://github.com/apache-superset/superset-ui-plugins/blob/master/CHANGELOG.md) - [Commits](apache-superset/superset-ui-plugins@v0.10.0...v0.11.0) Signed-off-by: dependabot-preview[bot] <[email protected]>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
Updates the requirements on [@data-ui/event-flow](https://github.com/williaster/data-ui) to permit the latest version. - [Release notes](https://github.com/williaster/data-ui/releases) - [Changelog](https://github.com/williaster/data-ui/blob/master/CHANGELOG.md) - [Commits](williaster/data-ui@v0.0.80...v0.0.81) Signed-off-by: dependabot-preview[bot] <[email protected]>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
…rement (apache#213) Updates the requirements on [@superset-ui/legacy-preset-chart-big-number](https://github.com/apache-superset/superset-ui-plugins) to permit the latest version. - [Release notes](https://github.com/apache-superset/superset-ui-plugins/releases) - [Changelog](https://github.com/apache-superset/superset-ui-plugins/blob/master/CHANGELOG.md) - [Commits](apache-superset/superset-ui-plugins@v0.10.0...v0.11.0) Signed-off-by: dependabot-preview[bot] <[email protected]>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
Updates the requirements on [@data-ui/event-flow](https://github.com/williaster/data-ui) to permit the latest version. - [Release notes](https://github.com/williaster/data-ui/releases) - [Changelog](https://github.com/williaster/data-ui/blob/master/CHANGELOG.md) - [Commits](williaster/data-ui@v0.0.80...v0.0.81) Signed-off-by: dependabot-preview[bot] <[email protected]>
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug is introduced in this commit
https://github.com/airbnb/caravel/pull/188/files#diff-ba3aebfb9fa5aadd492450873088cd15R222
caused this error when viewing DruidDatasource.
@mistercrunch @hongbozeng